Skip to content

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Dec 6, 2022

part of #8200

Why

This PR adds the UI for the custom range date picker.

How

  • Adds a new reusable view that consists of two pickers laid out vertically.
  • Selected dates are returned in a completion block.

Note: Proper date format will come in a later PR as it involves more than UI logic.

Demo

demo.mov

Testing

The picker is not yet integrated into the app, but you can take a look at it in its preview.
Alternatively, you can launch the view in code, for example, by replacing the list selector from the analytics hub range types.

var body: some View {
        createTimeRangeContent()
            .sheet(isPresented: $showTimeRangeSelectionView) {
                RangedDatePicker
            }
}

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the category: tracks Related to analytics, including Tracks Events. label Dec 6, 2022
@Ecarrion Ecarrion added this to the 11.6 milestone Dec 6, 2022
@Ecarrion Ecarrion linked an issue Dec 6, 2022 that may be closed by this pull request
@wpmobilebot
Copy link
Collaborator

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8330-6a0ca6d on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ealeksandrov ealeksandrov self-assigned this Dec 7, 2022
Copy link
Contributor

@ealeksandrov ealeksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ealeksandrov ealeksandrov removed their assignment Dec 7, 2022
@Ecarrion Ecarrion merged commit a166a9f into trunk Dec 7, 2022
@Ecarrion Ecarrion deleted the issue/8200-prototype branch December 7, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tracks Related to analytics, including Tracks Events.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Analytics Hub] Add custom date range selection support

4 participants